fix: use afterRender to detect dashboard rendered #5970
Conversation
|
extended-test --isolated |
|
"extended-test --isolated" started. Check the progress here. |
|
❌ "extended-test --isolated" finished with result failure. Check the results here. |
pbenes
force-pushed
the
pb-afterrender-ff
branch
from
d006752 to
e7acefb
Compare
|
extended-test --isolated |
|
"extended-test --isolated" started. Check the progress here. |
|
✅ "extended-test --isolated" finished with result success. Check the results here. |
|
extended-test --integrated |
|
"extended-test --integrated" started. Check the progress here. |
|
✅ "extended-test --integrated" finished with result success. Check the results here. |
pbenes
force-pushed
the
pb-afterrender-ff
branch
from
aaaa5e8 to
e7acefb
Compare
|
extended-test --isolated |
|
"extended-test --isolated" started. Check the progress here. |
|
✅ "extended-test --isolated" finished with result success. Check the results here. |
pbenes
force-pushed
the
pb-afterrender-ff
branch
2 times, most recently
from
ef39633 to
89be2a2
Compare
libs/sdk-ui-charts/src/charts/headline/internal/headlines/LegacyHeadline.tsx
Show resolved
Hide resolved
| @@ -48,19 +50,33 @@ export default class LegacyHeadline extends React.Component<IHeadlineVisualizati | |||
| disableDrillUnderline: false, | |||
| }; | |||
|
|
|||
| private secondaryItemTitleWrapperRef = createRef<HTMLDivElement>(); | |||
| private afterRenderGuardTimeoutId; | |||
| private afterRenderCalled = false; | |||
There was a problem hiding this comment.
what it purpose of this guard? never set to true afterRenderCalled
There was a problem hiding this comment.
fixed, and used the guard
libs/sdk-ui-charts/src/charts/headline/internal/headlines/baseHeadline/BaseHeadline.tsx
Outdated
Show resolved
Hide resolved
pbenes
force-pushed
the
pb-afterrender-ff
branch
2 times, most recently
from
ec96e81 to
350d503
Compare
|
extended-test --isolated |
|
"extended-test --isolated" started. Check the progress here. |
|
✅ "extended-test --isolated" finished with result success. Check the results here. |
Hidden under enableDashboardAfterRenderDetection feature flag. Contains fixes for headlines, introduced afterRender method for Repeater chart. Note: vis switcher executes only a single visualization and then relies on executedActions.setDashboardExecutionDone() to initiate other executions. Moreover, it does it through DashboardInsight so the mechanism should remain working. risk: low JIRA: STL-138
pbenes
force-pushed
the
pb-afterrender-ff
branch
from
350d503 to
1186fa7
Compare
|
extended-test --isolated |
|
"extended-test --isolated" started. Check the progress here. |
|
✅ "extended-test --isolated" finished with result success. Check the results here. |
Hidden under enableDashboardAfterRenderDetection feature flag.
Contains fixes for headlines, introduced afterRender method
for Repeater chart.
Note: vis switcher executes only a single visualization and then
relies on executedActions.setDashboardExecutionDone() to initiate
other executions. Moreover, it does it through DashboardInsight so
the mechanism should remain working.
risk: low
JIRA: STL-138
Important
Please, don't forget to run
rush changefor the commits that introduce new features or significant changes 🙏 This information is used to generate the change log.Run extended test by pull request comment
Commands can be triggered by posting a comment with specific text on the pull request. It is possible to trigger multiple commands simultaneously.
Explanation
--backstopThe command to run screen tests.--integratedThe command to run integrated tests against the live backend.--isolatedThe command to run isolated tests against recordings.--recordThe command to create new recordings for isolated tests.--filter(Optional) A comma-separated list of test files to run. This parameter is valid only for the--integrated,--isolated, and--recordcommands.Examples