Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the issue #17 #18

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix the issue #17 #18

wants to merge 3 commits into from

Conversation

GCorbel
Copy link

@GCorbel GCorbel commented Aug 30, 2013

It works for me

@chalmagean
Copy link

it should probably be find(:css, drop_container).find(:css, ".select2-result-label").click since the span is used to match the searched text

@GCorbel
Copy link
Author

GCorbel commented Sep 2, 2013

Both are working.

I made a benchmark and this is the result :

select2-result-label  1.150000   0.510000   1.660000 (  3.041824)
select2-match  1.050000   0.440000   1.490000 (  2.712075)

So, for speed, it's better to use "select2-match". Do you see another reason than speed?

@chalmagean
Copy link

select2-match is empty, unless you do a search

@GCorbel
Copy link
Author

GCorbel commented Sep 2, 2013

I did the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GCorbel @chalmagean