Ignore bad return type annotation in convert_seed_and_sample_shape #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_565142299
branch
2 times, most recently
from
e0d994d
to
c19b7c9
Compare
copybara-service
bot
force-pushed
the
test_565142299
branch
from
c19b7c9
to
90f7611
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore bad return type annotation in convert_seed_and_sample_shape
Why? This annotation is incorrect (the type checker does not consider
rnghere to be aPRNGKey) The reason this has worked in the past is becausechex.PRNGKeyhas been effectively considered to beAny; this incorrect annotation is blocking us from makingchex.PRNGKeya more meaningful annotation.