Skip to content

Commit

Permalink
Merge pull request #1282 from nadavhalahmi:patch-1
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 688132233
Change-Id: I5f92d19358b19cb1205cec2747508598d94e9fd0
  • Loading branch information
lanctot committed Oct 21, 2024
2 parents e216731 + 78645a7 commit 1560a35
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion docs/concepts.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ There are mainly 2 concepts to know about (defined in
* A `Game` object contains the high level description for a game (e.g. whether
it is simultaneous or sequential, the number of players, the maximum and
minimum scores).
* A `State`, which describe a specifics point (e.g. a specific board position
* A `State`, which describes a specific point (e.g. a specific board position
in chess, a specific set of player cards, public cards and past bets in
Poker) within a trajectory.

Expand Down
16 changes: 8 additions & 8 deletions docs/install.md
Original file line number Diff line number Diff line change
Expand Up @@ -116,11 +116,11 @@ In a nutshell:
pip3 install --upgrade setuptools testresources
```

Additionally, if you intend to use one of the
optional Python dependencies (see [open_spiel/scripts/install.sh](https://github.com/deepmind/open_spiel/blob/master/open_spiel/scripts/install.sh)), you
must manually install and/or upgrade them, e.g.: `bash pip install --upgrade
torch==x.xx.x jax==x.x.x` where `x.xx.x` should be the desired version
numbers (which can be found at the link above).
Additionally, if you intend to use one of the optional Python dependencies
(see [open_spiel/scripts/install.sh](https://github.com/deepmind/open_spiel/blob/master/open_spiel/scripts/install.sh)), you must manually
install and/or upgrade them, e.g.: `bash pip install --upgrade torch==x.xx.x
jax==x.x.x` where `x.xx.x` should be the desired version numbers (which can
be found at the link above).

4. This sections differs depending on the installation procedure:

Expand Down Expand Up @@ -152,8 +152,8 @@ In a nutshell:
export PYTHONPATH=$PYTHONPATH:/<path_to_open_spiel>/build/python
```

to `./venv/bin/activate` or your `~/.bashrc` to be able to import OpenSpiel
from anywhere.
add it to `./venv/bin/activate` or your `~/.bashrc` to be able to import
OpenSpiel from anywhere.

To make sure OpenSpiel works on the default configurations, we do use the
`python3` command and not `python` (which still defaults to Python 2 on modern
Expand Down Expand Up @@ -320,7 +320,7 @@ rest) from any location, you will need to add to your PYTHONPATH the root
directory and the `open_spiel` directory.

When using a virtualenv, the following should be added to
`<virtualenv>/bin/activate`. For a system-wide install, ddd it in your `.bashrc`
`<virtualenv>/bin/activate`. For a system-wide install, add it in your `.bashrc`
or `.profile`.

```bash
Expand Down

0 comments on commit 1560a35

Please sign in to comment.