-
Notifications
You must be signed in to change notification settings - Fork 963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to Spades #1242
Updates to Spades #1242
Conversation
Now can get/set scores and set a bonus reward for winning/losing overall game to returns.
Hi @i-Madsen, thanks for the updates! Can you pull changes from master and merge them into your branch? I had to make some cosmetic changes to your code to adhere to the required style. (If you can keep these persistent and apply them elsewhere too, that'd be great.) Once any conflicts are resolved, please push the merge commit. |
Also, note: I will soon not have access to the Internet for the next 8-10 days.. so apologies for any delays in responses. |
Ok, think I've got it all merged correctly and pushed once you get back. Let me know if I missed anything. Edit: I do see it's failing checks on here, but I'm not what's different that's causing it. |
@lanctot Ok, should be merged now. |
Ok seems there are some test failures for legitimate reasons (a function is marked void but I guess it's returning a bool?) Can you take a look and push a fix? |
@lanctot Looks like it's all passing now (not sure how I missed that before). |
Now can get/set scores and set a bonus reward for winning/losing overall game to returns.