CI: test against nightly JAX #1173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failures point to code added earlier today in #1169 |
|
Looks like #1172 should fix the failures; I'll rebase on that once it's merged. |
jakevdp
force-pushed
the
ci-nightly-jax
branch
from
ca82fd4 to
b36f6c2
Compare
|
Chatting with @rdyro it seems the test failure is probably related to JAX enabling partitionable threefry by default (jax-ml/jax#25363). This change is discussed at jax-ml/jax#18480: This is a new RNG scheme that produces different draws from the same distribution; that change was enough to just exceed the test tolerance with the new random draws. The best fix is probably to bump the test tolerance. |
jakevdp
force-pushed
the
ci-nightly-jax
branch
from
48a9c90 to
e88b54c
Compare
rdyro
approved these changes
Jan 14, 2025
jakevdp
force-pushed
the
ci-nightly-jax
branch
3 times, most recently
from
d02396b to
dfcfc98
Compare
jakevdp
force-pushed
the
ci-nightly-jax
branch
from
dfcfc98 to
4e577e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will catch potential incompatibilities introduced in JAX before they make it into a release.
Also update parts of the workflow definition to reflect current best practices.