Isolate treescope renderings to improve performance and duplication-safety. #52
+550
−333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_648720934
branch
from
b97c1c0
to
c842aea
Compare
…afety. Includes a number of changes to improve the robustness and performance of treescope output renderings: - Isolates each rendering in the "Shadow DOM", ensuring CSS styles do not conflict between different renderings. - Isolates JS definitions as properties of a custom container element, avoiding conflicts between different output versions. - Adds duplication safety: making two copies of a treescope rendering will correctly render it twice instead of having interference between copies. - Improves performance by adding CSS container content visibility annotations. This change should significantly improve performance and responsiveness of Penzai's visualizations when used in a notebook environment like JupyterLab, which does not apply strong sandboxing between different output cells. PiperOrigin-RevId: 649053637
copybara-service
bot
force-pushed
the
test_648720934
branch
from
c842aea
to
2c7bee8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Isolate treescope renderings to improve performance and duplication-safety.
Includes a number of changes to improve the robustness and performance of treescope
output renderings:
between different renderings.
conflicts between different output versions.
render it twice instead of having interference between copies.
This change should significantly improve performance and responsiveness of Penzai's
visualizations when used in a notebook environment like JupyterLab, which does not
apply strong sandboxing between different output cells.