Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates Event Service to be generic & adds login and logout events #25

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Updates Event Service to be generic & adds login and logout events #25

wants to merge 8 commits into from

Conversation

jamessexton-io
Copy link
Collaborator

  • Replaced EcommerceEventsService with Events Service
  • Adds Login and Logout Events
  • Adds Login and logout events to Google Tag Manager dataLayer

tdsymonds
tdsymonds reviewed May 29, 2024
View reviewed changes
website/ui/src/app/models/user.ts Outdated Show resolved Hide resolved
website/ui/src/app/app.module.ts Outdated Show resolved Hide resolved
website/ui/src/app/services/events.service.ts Outdated Show resolved Hide resolved
website/ui/src/app/services/login.service.ts Outdated Show resolved Hide resolved
website/ui/src/app/models/events.ts Outdated Show resolved Hide resolved
website/ui/src/app/services/events.service.ts Outdated Show resolved Hide resolved
website/ui/src/app/services/login.service.ts Outdated Show resolved Hide resolved
website/ui/src/app/services/events.service.ts Outdated Show resolved Hide resolved
website/ui/src/app/services/events.service.ts Outdated Show resolved Hide resolved
website/ui/src/app/services/events.service.ts Outdated Show resolved Hide resolved
@tdsymonds tdsymonds reopened this Jun 3, 2024
@jamessexton-io
Copy link
Collaborator Author

@tdsymonds

Ignore this latest commit - need to remove some files that I added accidentally. It includes the business pages & leads forms which I'll add separately

tdsymonds
tdsymonds reviewed Jun 14, 2024
View reviewed changes
Copy link
Collaborator

@tdsymonds tdsymonds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of tiny things then you're good to go

website/ui/src/app/models/events.ts Show resolved Hide resolved
website/ui/src/app/services/events.service.ts Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdsymonds tdsymonds tdsymonds left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamessexton-io @tdsymonds