Fixing the dependencies going out of sync. #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
Brief synopsis: The protobuf version was fixed previously (due to python library incompatibilities), but the absl-cpp version is always taken from the HEAD. Since we were forcing the freshest absl-cpp upon protobufs, its internal version was ignored. We fix this by letting protobuf use whichever internal version it has currently configured. Further changes: 1. Refresh `rules-cc` and `rules-python`. 1. Use the freshest `protobuf` library. 1. Remove previous fixed protobuf version with external patch. PiperOrigin-RevId: 568845133
copybara-service
bot
force-pushed
the
cl/568823387
branch
from
de83e82 to
9d3ef16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the dependencies going out of sync.
Brief synopsis: The protobuf version was fixed previously (due to python
library incompatibilities), but the absl-cpp version is always taken from the
HEAD. Since we were forcing the freshest absl-cpp upon protobufs, its internal
version was ignored. We fix this by letting protobuf use whichever internal
version it has currently configured.
Further changes:
rules-ccandrules-python.protobuflibrary.