Datalog IR; Translate AuthLogic to DLIR #261

aferr · 2022-01-07T14:18:13Z

This is a port of the datalog ir referred to as
DLIR
and the compiler pass that translates auth logic AST nodes into DLIR
here
from the rust implementations into CPP.

This is a port of the datalog ir referred to as [DLIR](https://github.com/google-research/raksha/blob/main/rust/tools/authorization-logic/src/souffle/datalog_ir.rs) and the compil pass that translates auth logic AST nodes into DLIR [here](https://github.com/google-research/raksha/blob/main/rust/tools/authorization-logic/src/souffle/lowering_ast_datalog.rs) from the rust implementations into CPP.

src/ir/auth_logic/ast.h

src/ir/auth_logic/lowering_ast_datalog.h

src/ir/auth_logic/datalog_ir.h

src/ir/auth_logic/lowering_ast_datalog.h

aferr · 2022-01-17T17:01:26Z

@markww now it might be a good point to do a re-review just at the is this good C++ level and not so much at the does this algorithm make sense level (I'll add better comments to justify the second one later). See what you think of the way variants are visited (in particular that an accessor to the variant is added back in). Also I think I needed to add more const references to iterate over vectors... maybe some of these can actually be eliminated somehow, though?

src/ir/auth_logic/ast.h

src/ir/auth_logic/datalog_ir.h

src/ir/auth_logic/lowering_ast_datalog.h

src/ir/auth_logic/ast.h

src/ir/auth_logic/datalog_ir.h

src/ir/auth_logic/lowering_ast_datalog.h

bgogul

This is a lot of code without tests, but I understand that you want to iterate. :) Address the comments when you get a chance. We will do iterate once more and get this in.

src/ir/auth_logic/ast.h

src/ir/auth_logic/datalog_ir.h

src/ir/auth_logic/lowering_ast_datalog.h

src/ir/auth_logic/lowering_ast_datalog.cc

bgogul

Some more code refactoring suggestions. Also, some of the changes (like copyright change) don't seem to be in the PR.

src/ir/auth_logic/ast.h

src/ir/auth_logic/datalog_ir.h

src/ir/auth_logic/lowering_ast_datalog.cc

src/ir/auth_logic/lowering_ast_datalog.h

src/ir/auth_logic/lowering_ast_datalog.cc

src/ir/auth_logic/move_append.h

src/ir/auth_logic/lowering_ast_datalog.cc

src/ir/auth_logic/lowering_ast_datalog.h

src/ir/auth_logic/lowering_ast_datalog.cc

aferr · 2022-02-09T11:54:42Z

@bgogul opened issue #346

bgogul

Looks good modulo some more comments.

src/ir/auth_logic/lowering_ast_datalog.cc

Andrew Ferraiuolo added 3 commits January 7, 2022 14:17

Merge branch 'main' into lowering-to-datalog@aferr

48ca64d

Merge branch 'main' into lowering-to-datalog@aferr

262c3c2

markww reviewed Jan 10, 2022

View reviewed changes

Andrew Ferraiuolo added 6 commits January 11, 2022 11:14

Translate more AST nodes

ff5587f

PR fixup

4863d1d

PR Fixup

066a0e1

Drop const references

c8b363c

visit overloaded for AssertionVariantType

2e39ebd

base fact example

13854eb

aferr commented Jan 14, 2022

View reviewed changes

src/ir/auth_logic/lowering_ast_datalog.h Outdated Show resolved Hide resolved

Up to program with stubs

65d014a

aferr requested a review from markww January 17, 2022 16:59

Fill in more stubs

af60d7c

markww reviewed Jan 19, 2022

View reviewed changes

Andrew Ferraiuolo added 4 commits January 19, 2022 11:31

Finish CanSay translation

443aee5

Finish CanSay translation

228497b

Finish translation

bb4b4d4

Add comment from rust version

ba64572

aferr requested review from markww and bgogul January 19, 2022 14:05

markww reviewed Jan 19, 2022

View reviewed changes

src/ir/auth_logic/ast.h Outdated Show resolved Hide resolved

aferr changed the title ~~[WIP] Datalog IR; Translate AuthLogic to DLIR~~ Datalog IR; Translate AuthLogic to DLIR Jan 19, 2022

markww reviewed Jan 19, 2022

View reviewed changes

aferr force-pushed the lowering-to-datalog@aferr branch 2 times, most recently from 83c21e2 to ba64572 Compare January 20, 2022 09:22

Merge branch 'main' into lowering-to-datalog@aferr

95d2fa2

aferr mentioned this pull request Jan 20, 2022

[Authorization Logic // C++] Performance Improvement in Translation to Datalog #267

Open

PR Fixup

e63f264

aferr requested a review from bgogul January 25, 2022 13:06

aferr added 4 commits January 25, 2022 13:07

Merge branch 'main' into lowering-to-datalog@aferr

16dce4e

Fix BUILD

f8ed093

Lint

c34965d

fix ast_test.cc

c486e20

bgogul reviewed Jan 26, 2022

View reviewed changes

Andrew Ferraiuolo added 2 commits February 7, 2022 13:21

PR Fixup

f4320ee

Lint

a3e8382

aferr requested a review from bgogul February 7, 2022 13:30

Merge branch 'main' into lowering-to-datalog@aferr

745370b

bgogul reviewed Feb 8, 2022

View reviewed changes

Andrew Ferraiuolo added 7 commits February 9, 2022 09:36

Fix license

c0fd021

Move functions

2ffa54b

Extract GenerateDLIRAssertions

f5b9291

Inline queries

5c88680

MapIter

d9e5b98

Two more uses of MapIter

58f8e40

Move stateless functions out of header

0786f0c

Andrew Ferraiuolo added 2 commits February 9, 2022 12:00

Lint

d21f11e

Merge branch 'main' into lowering-to-datalog@aferr

d955140

aferr requested a review from bgogul February 9, 2022 14:55

bgogul approved these changes Feb 9, 2022

View reviewed changes

Andrew Ferraiuolo added 4 commits February 10, 2022 11:52

Try resetting Cargo.lock

8c57b5b

PR Fixup

9974976

Lint

854904c

Merge branch 'main' into lowering-to-datalog@aferr

cd90e62

aferr merged commit 55573ec into main Feb 10, 2022

aferr deleted the lowering-to-datalog@aferr branch February 10, 2022 12:41

Cypher1 added the authorization logic label Mar 14, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Datalog IR; Translate AuthLogic to DLIR #261

Datalog IR; Translate AuthLogic to DLIR #261

aferr commented Jan 7, 2022 •

edited

Loading

aferr commented Jan 17, 2022

bgogul left a comment

bgogul left a comment

aferr commented Feb 9, 2022

bgogul left a comment

Datalog IR; Translate AuthLogic to DLIR #261

Datalog IR; Translate AuthLogic to DLIR #261

Conversation

aferr commented Jan 7, 2022 • edited Loading

aferr commented Jan 17, 2022

bgogul left a comment

Choose a reason for hiding this comment

bgogul left a comment

Choose a reason for hiding this comment

aferr commented Feb 9, 2022

bgogul left a comment

Choose a reason for hiding this comment

aferr commented Jan 7, 2022 •

edited

Loading