Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visitor for authorization logic AST #643

Merged
merged 12 commits into from
Aug 18, 2022
Merged

Visitor for authorization logic AST #643

merged 12 commits into from
Aug 18, 2022

Conversation

aferr
Copy link
Collaborator

@aferr aferr commented Aug 9, 2022

No description provided.

@aferr
Copy link
Collaborator Author

aferr commented Aug 9, 2022

This directly applies the design for the visitor that operates on the main Raksha IR.

This fixes #345

@aferr aferr requested review from markww, Cypher1 and bgogul August 9, 2022 15:27
@aferr aferr marked this pull request as ready for review August 9, 2022 15:27
Cypher1
Cypher1 approved these changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@Cypher1 Cypher1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

src/ir/auth_logic/BUILD Show resolved Hide resolved
src/ir/ir_visitor.h Show resolved Hide resolved
markww
markww reviewed Aug 10, 2022
View reviewed changes
src/ir/auth_logic/ast.h Outdated Show resolved Hide resolved
src/ir/auth_logic/auth_logic_ast_traversing_visitor.h Outdated Show resolved Hide resolved
src/ir/auth_logic/auth_logic_ast_visitor.h Outdated Show resolved Hide resolved
src/ir/auth_logic/auth_logic_ast_visitor.h Outdated Show resolved Hide resolved
src/ir/auth_logic/auth_logic_ast_traversing_visitor.h Show resolved Hide resolved
src/ir/auth_logic/auth_logic_ast_traversing_visitor.h Outdated Show resolved Hide resolved
src/ir/auth_logic/auth_logic_ast_traversing_visitor.h Outdated Show resolved Hide resolved
src/ir/auth_logic/auth_logic_ast_traversing_visitor.h Outdated Show resolved Hide resolved
src/ir/auth_logic/auth_logic_ast_traversing_visitor.h Outdated Show resolved Hide resolved
@aferr aferr requested a review from markww August 10, 2022 11:51
markww
markww approved these changes Aug 10, 2022
View reviewed changes
Copy link
Contributor

@markww markww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo the last few (relatively minor) threads here.

bgogul
bgogul reviewed Aug 10, 2022
View reviewed changes
Copy link
Collaborator

@bgogul bgogul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some comprehensive tests? This is a lot of non-trivial code without sufficient tests.

src/ir/auth_logic/auth_logic_ast_traversing_visitor_test.cc Outdated Show resolved Hide resolved
src/ir/auth_logic/auth_logic_ast_traversing_visitor_test.cc Show resolved Hide resolved
src/ir/auth_logic/auth_logic_ast_traversing_visitor_test.cc Show resolved Hide resolved
src/ir/auth_logic/auth_logic_ast_traversing_visitor_test.cc Show resolved Hide resolved
@aferr aferr mentioned this pull request Aug 11, 2022
Open
@aferr aferr requested a review from bgogul August 12, 2022 14:04
@aferr
Copy link
Collaborator Author

aferr commented Aug 16, 2022

@bgogul I'm not blocked on this yet so I thought I would wait for you to re-review before merging it in. Let me know if it looks OK if you have a moment.

bgogul
bgogul approved these changes Aug 17, 2022
View reviewed changes
Copy link
Collaborator

@bgogul bgogul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but left some clean up comments. If you don't address these, can you file issues (e.g., gmock, debugprint as visitor, etc.)

Also, try to keep PRs smaller.

src/ir/auth_logic/ast.h Show resolved Hide resolved
src/ir/auth_logic/auth_logic_ast_traversing_visitor.h Outdated Show resolved Hide resolved
src/ir/auth_logic/auth_logic_ast_traversing_visitor_test.cc Show resolved Hide resolved
@aferr
Copy link
Collaborator Author

aferr commented Aug 18, 2022

Also, try to keep PRs smaller.

@bgogul Writing code in smaller increments doesn't come so naturally to me. This one seems like a self-contained increment to me. How would I split this into smaller self-contained PRs? Would it be to separately write:

  • just the visitor
  • then the traversing visitor + changes to the AST nodes
  • then add the test
    Or what would be a sensible way to split this into smaller PRs?

@aferr aferr merged commit e0ab6f8 into main Aug 18, 2022
@aferr aferr deleted the auth-ast-visitor@aferr branch August 18, 2022 12:45
aferr pushed a commit that referenced this pull request Aug 19, 2022
Visitor for authorization logic AST (#643)
f340a9e
@aferr aferr mentioned this pull request Aug 19, 2022
Closed
copybara-service bot pushed a commit that referenced this pull request Aug 19, 2022
@arcs-c3po
Visitor for authorization logic AST (#643)
0088890 
Closes #643

COPYBARA_INTEGRATE_REVIEW=#643 from google-research:auth-ast-visitor@aferr d3426cb
PiperOrigin-RevId: 468746566
@markww markww mentioned this pull request Aug 19, 2022
Closed
@aferr aferr mentioned this pull request Aug 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgogul bgogul bgogul approved these changes

@Cypher1 Cypher1 Cypher1 approved these changes

@markww markww markww approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aferr @markww @Cypher1 @bgogul