Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commented out lines of the verbs_in_action project for code cleanup #1067

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scenic/dataset_lib/video_ops.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
from dmvr import processors as dmvr_processors
import simclr.tf2.data_util as simclr_data
import tensorflow as tf
from official.vision.image_classification import augment
from official.vision.tasks.image_classification import augment


def _get_shape(x):
Expand Down
2 changes: 1 addition & 1 deletion scenic/projects/verbs_in_action/configs/baseline.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ def get_config(runlocal=''):
config.dataset_name = 'verbs_in_action_tfrecord_dataset'
config.dataset_configs = ml_collections.ConfigDict()
config.data_dtype_str = 'float32'
The tables here should be without hard negatives since this is the baseline training.
# The tables here should be without hard negatives since this is the baseline training.
config.dataset_configs.base_dir = 'your_base_directory'
config.dataset_configs.tables = {
'train': 'training_path',
Expand Down
4 changes: 2 additions & 2 deletions scenic/projects/verbs_in_action/configs/vfc.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@ def get_config(runlocal=''):
config.dataset_name = 'verbs_in_action_tfrecord_dataset'
config.dataset_configs = ml_collections.ConfigDict()
config.data_dtype_str = 'float32'
The `train` split should contain hard negative captions in the
"""The `train` split should contain hard negative captions in the
`caption/string_neg` field and positive caption in the `caption/strin_pos`
field of the tfrecord.
field of the tfrecord."""
config.dataset_configs.base_dir = 'your_base_directory'
config.dataset_configs.tables = {
'train': 'training_path',
Expand Down