-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NVIDIA] Added transformer engine support and GPU optimizations #1391
Open
terrykong
wants to merge
19
commits into
google-research:main
Choose a base branch
from
nvjax-svc-0:patch/t5x_te_in_contrib_noindent
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[NVIDIA] Added transformer engine support and GPU optimizations #1391
terrykong
wants to merge
19
commits into
google-research:main
from
nvjax-svc-0:patch/t5x_te_in_contrib_noindent
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
terrykong
commented
Sep 8, 2023
- Added Transformer Engine + FP8 support
- Updated T5x and jax version=0.4.11
- A100 Perf gains!
- 80% speedup - T5-small
- 23% speedup - T5-large
- 18% speedup - T5-xl
- 40% speedup - T5-xxl
- H100 support, with gains over A100
- 2.08x faster - T5-large
- 2.24x faster - T5-xl
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
terrykong
force-pushed
the
patch/t5x_te_in_contrib_noindent
branch
2 times, most recently
from
October 9, 2023 20:23
c82b280
to
443df5e
Compare
ashors1
force-pushed
the
patch/t5x_te_in_contrib_noindent
branch
from
November 28, 2023 06:43
4346418
to
d08a684
Compare
ashors1
force-pushed
the
patch/t5x_te_in_contrib_noindent
branch
from
January 8, 2024 21:38
74d742f
to
79bf053
Compare
terrykong
force-pushed
the
patch/t5x_te_in_contrib_noindent
branch
from
February 21, 2024 17:31
79bf053
to
3ca8e34
Compare
Co-authored-by: Sahil Jain <[email protected]> Co-authored-by: Terry Kong <[email protected]> Co-authored-by: Yu-Hang Tang <[email protected]> Co-authored-by: Ming Huang <[email protected]> Co-authored-by: Frederic Bastien <[email protected]> Co-authored-by: Sharath Turuvekere Sreenivas <[email protected]> Co-authored-by: Xiaowei Ren <[email protected]> Co-authored-by: Ryan Jeng <[email protected]> Co-authored-by: Reese Wang <[email protected]>
configs use packing (CV/Multimodal)
Updated T5x-large MNLI and SQUAD baselines
Co-authored-by: NVIDIA <[email protected]>
…e_fp8 (#8) * Allows ENABLE_TE env var to control whether TE code path is invoked * Changes enabled -> enable_fp8 to be more consistent with PAX and avoid confusion with ENABLE_TE * Remove UNINSTALL_TE logic since it is no longer required --------- Co-authored-by: NVIDIA <[email protected]>
… of input variables (#9) * Update multiprocess scripts * No longer need UNINSTALL_TE * Removes slurm scripts as the source of truth has moved to rosetta * Adds "Finished" message to multiprocess scripts * Remove BENCHMARK_ARGS which is no longer used * Fix typo in BENCHMARK_MODE and straggling if keyword * Address comments
terrykong
force-pushed
the
patch/t5x_te_in_contrib_noindent
branch
from
March 8, 2024 17:57
3ca8e34
to
06be7c2
Compare
Signed-off-by: Reese Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.