Create abstraction for pthread_once()/InitOnceExecuteOnce() calls to avoid boilerplate code in many places and also to make other implementations possible. #6804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
…avoid boilerplate code in many places and also to make other implementations possible. Some (e.g.) DSP targets don't have a working version of pthreads, so we can't rely on `pthreads_once()`. This provides a single bottleneck we can use to customize for those targets (rather than dozens spread across dozens of files), and makes the code pleasantly terser. Note that this change should be functionally a no-op, just code refactoring to make upcoming changes more seamless. PiperOrigin-RevId: 659754591
copybara-service
bot
force-pushed
the
test_659672037
branch
from
f1f7e46 to
4f09c54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create abstraction for pthread_once()/InitOnceExecuteOnce() calls to avoid boilerplate code in many places and also to make other implementations possible.
Some (e.g.) DSP targets don't have a working version of pthreads, so we can't rely on
pthreads_once(). This provides a single bottleneck we can use to customize for those targets (rather than dozens spread across dozens of files), and makes the code pleasantly terser.Note that this change should be functionally a no-op, just code refactoring to make upcoming changes more seamless.