Add XNN_HAS_MMAP to common.h, as a way to indicate that a given platform doesn't support mmap() at all and must fall back to malloc() instead. #6816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_660438085
branch
from
59bb2f6 to
1cc2593
Compare
…orm doesn't support mmap() at all and must fall back to malloc() instead. Note that it's initially (effectively) unused, since it's only set to 0 for Windows, which already has its own custom code path for memory allocation; however, this flag will be used for at least one upcoming target and landing it separately from introduction of that target seems easier to review. PiperOrigin-RevId: 660509451
copybara-service
bot
force-pushed
the
test_660438085
branch
from
1cc2593 to
197d184
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add XNN_HAS_MMAP to common.h, as a way to indicate that a given platform doesn't support mmap() at all and must fall back to malloc() instead.
Note that it's initially (effectively) unused, since it's only set to 0 for Windows, which already has its own custom code path for memory allocation; however, this flag will be used for at least one upcoming target and landing it separately from introduction of that target seems easier to review.