Replace vld1_dup_X with vdup_n_X #7592
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
I think the vld1_* form is dangerous, because if the scalar type differs, it accesses a different amount of memory than the type indicates. And if the type matches, at least clang produces identical intermediate code anyways: https://godbolt.org/z/Gc4EK67jM This should fix many warnings. PiperOrigin-RevId: 704890593
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace vld1_dup_X with vdup_n_X
I think the vld1_* form is dangerous, because if the scalar type differs, it accesses a different amount of memory than the type indicates. And if the type matches, at least clang produces identical intermediate code anyways: https://godbolt.org/z/Gc4EK67jM
This should fix many warnings.