Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ibilinear yaml with table header #7612

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Replace ibilinear yaml with table header #7612

wants to merge 3 commits into from

Conversation

RahulSundarMCW
Copy link
Contributor

No description provided.

dsharlet
dsharlet reviewed Dec 19, 2024
View reviewed changes
src/xnnpack/ibilinear.h Outdated
DECLARE_S8_IBILINEAR_UKERNEL_FUNCTION(xnn_s8_ibilinear_ukernel__wasmsimd_mul32_c16)

#define DECLARE_U8_IBILINEAR_UKERNEL_FUNCTION(fn_name) \
#define XNN_UKERNEL(arch_flags, fn_name, channel_tile, pixel_tile, datatype, params_type, init_params) \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a weights_datatype to the XNN_UKERNEL for these, then you can handle all of the datatypes with one definition.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@RahulSundarMCW RahulSundarMCW force-pushed the ibilinear branch 2 times, most recently from cffddac to 4009f44 Compare December 23, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsharlet dsharlet dsharlet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RahulSundarMCW @dsharlet