Add info grey box in calculated expression behavior screen in catalog app #1679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PallaviGanorkar
requested review from
aditya-07,
deepankarb,
jingtang10,
jjtswan,
joiskash,
kevinmost,
ktarasenko,
omarismail94,
santosh-pingle,
stevenckngaa,
vvikramraj,
wantingzhang77 and
yigit
as code owners
PallaviGanorkar
force-pushed
the
pg/1525_greybox_for_info_in_calculated_expression
branch
from
38319c5 to
3100dce
Compare
jingtang10
changed the title
jingtang10
approved these changes
Nov 2, 2022
|
please add a screenshot before merging |
|
ktarasenko
pushed a commit
to ktarasenko/android-fhir
that referenced
this pull request
Nov 7, 2022
ktarasenko
pushed a commit
to ktarasenko/android-fhir
that referenced
this pull request
Nov 14, 2022
ktarasenko
added a commit
that referenced
this pull request
Nov 23, 2022
* Add Implementation guide management library module * Crashed Fixed in Quantity Input Widget (#1673) * Crashed Fixed in Quantity Input Widget * reverted unwanted changes * Spotless check applied * remove clear answer from factory Co-authored-by: omarismail <[email protected]> * Fix review comments * Updated code to set the radio button in a radio group using radio groups check api instead of radio button apis (#1691) * Bump up SDC version to beta06 (#1694) * Follow up code health fixes of PR 1442 (#1631) * WIP PR feedback * spotless ran * added test cases for validation util * used fhirpathengine instance from fhir path expression evaluator * updated test cases name and convention * updated test cases name and their convention to look consistent Co-authored-by: Jing Tang <[email protected]> * Disable leniency in DateFormat lib when converting date (#1687) * Fix Issue #1638: disable lenient check * add espresso test * add more tests per date field changed * Regenerate docs after SDC version bump (#1696) * Documentation Update : Changed the folder structure and did some other minor add-ons (#1662) * Create CODE_OF_CONDUCT.md * Delete CODE_OF_CONDUCT.md * Create Contributing.md * Delete contributing.md * Update README.md * Update README.md Co-authored-by: Omar Ismail <[email protected]> * Catlog app- Info grey box added in Calculated expression screen Behavior (#1679) * Scroll down the recyclerview to show the Add answer button. (#1666) * Scroll down the recyclerview to show the Add answer button. * Address review comments. * Address review comments. * Add flaky flag to retry * update gcloud components as well * remove version flag Co-authored-by: Santosh Pingle <[email protected]> Co-authored-by: Omar Ismail <[email protected]> Co-authored-by: omarismail <[email protected]> * Enable "Next button" on paginated view when nested answer is chosen (#1684) Fix Issue #1677 * Add trailing line break. * Update buildSrc/src/main/kotlin/Releases.kt Co-authored-by: Jing Tang <[email protected]> Co-authored-by: PallaviGanorkar <[email protected]> Co-authored-by: omarismail <[email protected]> Co-authored-by: aditya-07 <[email protected]> Co-authored-by: Omar Ismail <[email protected]> Co-authored-by: aurangzaibumer <[email protected]> Co-authored-by: Jing Tang <[email protected]> Co-authored-by: Vanshaj Poonia <[email protected]> Co-authored-by: santosh-pingle <[email protected]> Co-authored-by: Santosh Pingle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #1525
Description
feature in ticket #1525 was partially implemented as part of PR #1380.
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: Feature
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.