-
Notifications
You must be signed in to change notification settings - Fork 19
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix item spacing of list replacement content in squoosh (#1686)
Fixes #1541. Set the default flex_grow value to 0 for list replacement items. This prevents the items in the list from stretching to fit the container they are in. This change puts several of the validation tests previously in the DEFAULT_RENDERER_ONLY category into the BOTH category. Squoosh is now able to render these examples correctly, with some (CrossAxis Fill) being more correct than the non-squoosh version.
- Loading branch information
Showing
8 changed files
with
24 additions
and
21 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+34.9 KB
...validation/src/testDebug/roborazzi/RenderAllExamples/CrossAxis-Fill_SQUOOSH.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+93 KB
...s/validation/src/testDebug/roborazzi/RenderAllExamples/Item-Spacing_SQUOOSH.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+14.1 KB
...dation/src/testDebug/roborazzi/RenderAllExamples/Layout-Replacement_SQUOOSH.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+25.3 KB
...s/validation/src/testDebug/roborazzi/RenderAllExamples/Layout-Tests_SQUOOSH.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+42.8 KB
...ion/src/testDebug/roborazzi/RenderAllExamples/Recurse-Customization_SQUOOSH.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+50.4 KB
...tion/src/testDebug/roborazzi/RenderAllExamples/Variant-Interactions_SQUOOSH.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.