Make iTime an optional uniform #2015
Open
+49
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiqunw700
force-pushed
the
yiqunw/iTime
branch
from
4fd4825 to
e997602
Compare
|
Snapshot diff report vs base branch: main |
yiqunw700
force-pushed
the
yiqunw/shader_int_uniform
branch
2 times, most recently
from
957ae48 to
746337a
Compare
yiqunw700
force-pushed
the
yiqunw/iTime
branch
2 times, most recently
from
851f577 to
97eb7ba
Compare
yiqunw700
force-pushed
the
yiqunw/shader_int_uniform
branch
from
746337a to
ffb75be
Compare
yiqunw700
force-pushed
the
yiqunw/iTime
branch
from
97eb7ba to
1cb8636
Compare
Towards: #1830
yiqunw700
force-pushed
the
yiqunw/iTime
branch
from
1cb8636 to
45cc53e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1830
After this change,
iTimedoes not always present in the shader code. It will require user to create one if it is used in the shader code. This way, the FrameRender doesn't need to handle iTime as a special case.automotive-design-compose/designcompose/src/main/java/com/android/designcompose/FrameRender.kt
Line 755 in 6bfc119