Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Hacker Mode Theme #1988 #2083

Closed
wants to merge 7 commits into from

Conversation

shivalipatel6
Copy link
Contributor

The basics

The details

Resolves

Fixes

Proposed Changes

Creates a new theme called Hacker Mode, it is currently unfinished due to some CSS issues but will be finished when that is done.

Reason for Changes

Test Coverage

All my intended changes shows in the browser.

Documentation

Once the theme is ready for production, documentation on how to install and how to use will be needed

Additional Information

shivalipatel6 and others added 7 commits October 31, 2023 15:28
deleted lint.js file, as well as removing it from the "available scripts" in dev-scripts/bin/blockly-scripts.js.
Created a new theme with black background, black block fill for each block, white highlight (Couldn't figure out boarders), dark toolbox, dark flyout, monospace text, The green text is not completed due to some css issues
Created theme with black background, black box fill, a white highlight (still figuring out how to set a boarder color), dark toolbox, dark flyout, and monospade text. I am still figuring out the green text due to CSS issues.
…le#2081

Replaced text on line 318 with a better discription for the plugin
@shivalipatel6 shivalipatel6 requested a review from a team as a code owner November 29, 2023 19:55
@shivalipatel6 shivalipatel6 requested review from BeksOmega and removed request for a team November 29, 2023 19:55
@BeksOmega
Copy link
Contributor

Sorry I missed a step in my instructions before! You're also going to need to run an interactive rebase to drop some commits.

  1. git switch master
  2. git pull upstream master (assuming google/blockly-samples is called upstream)
  3. git push origin master (assuming your fork is called origin)
  4. git switch feat/hacker-mode
  5. git rebase -i master
  6. Drop the fixing text commit.
  7. git log and check that the commits are correct.
  8. git push --force origin feat/hacker-mode

@shivalipatel6 shivalipatel6 deleted the feat/hacker-mode branch December 4, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants