fix: Fix text for the disable top blocks plugin on the demo page #2081 #2084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deleted lint.js file, as well as removing it from the "available scripts" in dev-scripts/bin/blockly-scripts.js.
Created a new theme with black background, black block fill for each block, white highlight (Couldn't figure out boarders), dark toolbox, dark flyout, monospace text, The green text is not completed due to some css issues
Created theme with black background, black box fill, a white highlight (still figuring out how to set a boarder color), dark toolbox, dark flyout, and monospade text. I am still figuring out the green text due to CSS issues.
…le#2081 Replaced text on line 318 with a better discription for the plugin
shivalipatel6
requested review from
maribethb
and removed request for
a team
maribethb
requested changes
Nov 29, 2023
- @blockly/[email protected] - @blockly/[email protected] - @blockly/[email protected]
* Fixed workscpace-minimap/focus_region.ts type errors Added various type checks and changes to focus_region.ts which follows proper standards for the TypeScript "strict-mode" compiler checks. * fixed type errors in workspace-minimap/minimap.ts Fixed all type error in ordinance with TypeScript's "strict-mode" * Updated workspace-minimap to utilize TS strict-mode Fully updated and fixed all type errors after enabling strict-mode. * Updated index.ts to follow strict-mode rules * fix lint errors in index.ts * Updated testing file to coordinate with strict-mode * Added requested changes Added the changes request under the PR * Added feedback changes * Removed JSDOM test code Removed the JSDOM code found in `plugins/workspace-minimap/test/minimap-test.mocha.js` as it was unnecessary due to updates to the code. * format files using prettier
- @blockly/[email protected]
Thanks to Paraminder Saund for pointing this out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes
It fixes some wording issues in the demo document for the disable top blocks plugin.
Proposed Changes
Reason for Changes
Test Coverage
Documentation
Additional Information