feat: create createBackingVariable method #2106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created a protected method that creates the variable for observable_parameter_model to make the class easier to subclass
shivalipatel6
requested review from
NeilFraser
and removed request for
a team
|
@shivalipatel6 I think this looks great! Can you call the protected function from the constructor? I think if you do that it's no longer a breaking change. |
This will change my last commit from a breaking change to a non-breaking change.
ran npm ci and npm run format to find my formatting errors and fix them
BeksOmega
reviewed
Dec 18, 2023
| * @returns This parameter model. | ||
| */ | ||
|
|
||
| protected createBackingVariable(name: string, varId?: string): this { |
There was a problem hiding this comment.
Sorry I should have asked for this change in my last review :/
Could you actually change this to return the new variable instead of assigning it? Then you can assign it in the constructor. That way all of the side effects are localized to the constructor, and people overriding this function don't have to remember to do the side effect!
Then this should be good to go =)
changed the return type of createBackingVariable so that it returns the variable itself.
ran npm ci and npm run format to address formatting errors in the pr
shivalipatel6
changed the title
BeksOmega
approved these changes
Jan 2, 2024
plugins/block-shareable-procedures/src/observable_parameter_model.ts
Outdated
Show resolved
Hide resolved
plugins/block-shareable-procedures/src/observable_parameter_model.ts
Outdated
Show resolved
Hide resolved
|
This looks great! Thank you so much @shivalipatel6 =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a protected method that creates the variable for observable_parameter_model to make the class easier to subclass
The basics
The details
Resolves
Fixes #1861
Proposed Changes
Creates a new method in the ObservableParameterModel class that will be used to create new variables instead of using the constructor.
Reason for Changes
Makes the class easier to subclass when a developer wants to create a typed variable.
Test Coverage
I ran the test class in the block-shareable-procedure files and it ran.
Documentation
Additional Information