Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test commands build #888

Closed

Conversation

fantonangeli
Copy link

Fixes #887

  • npm run test succeeds.
    Because this PR is just to re-enable non-running tests some tests is failing locally to me. But I guess it's because of permissions on GDrive.
    73 passing
    26 pending
    16 failing

  • npm run lint succeeds.

  • Appropriate changes to README are included in PR.

@google-cla google-cla bot added the cla: no label Nov 18, 2021
@fantonangeli fantonangeli marked this pull request as draft November 18, 2021 17:53
@fantonangeli fantonangeli marked this pull request as ready for review November 18, 2021 17:54
@fantonangeli
Copy link
Author

@googlebot rescan

@sqrrrl
Copy link
Member

sqrrrl commented Jan 8, 2025

Appreciate the pull request, but was just fixed as part of some other changes. Closing

@sqrrrl sqrrrl closed this Jan 8, 2025
@fantonangeli fantonangeli deleted the fix-test-commands-build branch January 8, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test/commands tests are not built
3 participants