Skip to content

Commit

Permalink
Add missing CLIF_DEPS for callback_test (this was accidentally miss…
Browse files Browse the repository at this point in the history
…ing in cl/584061498).

The `add_pyclif_library_for_test` function needs to be tweaked to accommodate the new use case.

GitHub testing: #84

PiperOrigin-RevId: 589940906
  • Loading branch information
rwgk committed Dec 11, 2023
1 parent 18699c5 commit 317bacf
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion clif/testing/python/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,14 @@ add_custom_target(runPyClifIntegrationTests
#
# $> ninja [pyclif_library_target_name]_test
function(add_pyclif_library_for_test name)
cmake_parse_arguments(PYCLIF_TEST_LIBRARY "" "" "TEST;PY_DEPS" ${ARGN})
cmake_parse_arguments(PYCLIF_TEST_LIBRARY "" "" "TEST;PY_DEPS;CLIF_DEPS" ${ARGN})
if (NOT DEFINED PYCLIF_TEST_LIBRARY_TEST)
set(PYCLIF_TEST_LIBRARY_TEST "${name}_test.py")
endif()

add_pyclif_library(${name}
${ARGN}
CLIF_DEPS ${PYCLIF_TEST_LIBRARY_CLIF_DEPS}
)

clif_target_name(${name} lib_target_name)
Expand Down Expand Up @@ -85,6 +86,7 @@ add_pyclif_library_for_test(add_init_and_property add_init_and_property.clif)

add_pyclif_library_for_test(callback callback.clif
PY_DEPS clif_python_callback_exception_guard
CLIF_DEPS clif_testing_python_copy_move_types_library
)

add_pyclif_library_for_test(call_method call_method.clif)
Expand Down

0 comments on commit 317bacf

Please sign in to comment.