testing cl/589875674

google · Dec 11, 2023 · b74f817 · b74f817
1 parent 2551c40
commit b74f817
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/clif/python/BUILD b/clif/python/BUILD
@@ -106,6 +106,7 @@ cc_library(
         "//clif/python/clif:__pkg__",
     ],
     deps = [
+        "@com_google_absl//absl/strings:string_view",
         "@com_google_protobuf//:protobuf",
         "@com_google_protobuf//:protobuf_headers",
     ],

diff --git a/clif/python/proto_util.cc b/clif/python/proto_util.cc
@@ -20,6 +20,8 @@
 #include <string>
 #include <vector>
 
+#include "absl/strings/string_view.h"
+
 #include "google/protobuf/compiler/importer.h"
 #include "google/protobuf/descriptor.h"
 #include "proto_util.h"
@@ -39,8 +41,8 @@ class ProtoFileErrorCollector : public MultiFileErrorCollector {
   explicit ProtoFileErrorCollector(std::string* error_str)
       : error_str_(error_str) {}
 
-  void AddError(const std::string& file, int line, int col,
-                const std::string& msg) override {
+  void RecordError(absl::string_view file, int line, int col,
+                   absl::string_view msg) override {
     std::ostringstream stream;
     stream << "Error parsing " << file;
     if (line > 0) {