Move the "Trait Bounds" slide right after "Generic Functions". #2589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "Generic Data Types" slide now uses trait bounds, which makes it very confusing to explain. (e.g., "ignore this trait bound stuff while I explain why we need to stutter to describe the generic args on an impl block"). Also in the "Generic Functions" slide, the speaker notes talks about how we essentially need to treat the generic args as black boxes - this is probably more important to address then talking about all the ways you can make things generic.
randomPoison
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
I think this is a good change. Even before the changes to the generic data types slide I had been thinking it'd be better to cover trait bounds first and then go over generic data types and generic trait. I think this is a good change for the flow of the slides.
|
Agreed; students are often champing at the bit to ask how they can limit generics to only certain sets of types, and usually I have to tell them to wait a few slides before we get there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Generic Data Types" slide now uses trait bounds, which makes it very confusing to explain. (e.g., "ignore this trait bound stuff while I explain why we need to stutter to describe the generic args on an impl block").
Also in the "Generic Functions" slide, the speaker notes talks about how we essentially need to treat the generic args as black boxes - this is probably more important to address then talking about all the ways you can make things generic.