Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util/resolve/maven: do not ignore direct test and optional dependencies #195

Merged
merged 4 commits into from
Mar 7, 2025

Conversation

cuixq
Copy link
Collaborator

@cuixq cuixq commented Feb 28, 2025

Considering that we are running the resolver on pom.xml directly instead of as a package consumer, we should not ignore direct test and optional dependencies.

@cuixq cuixq requested a review from fgalilee February 28, 2025 03:55
@cuixq cuixq marked this pull request as ready for review February 28, 2025 03:58
@cuixq cuixq requested a review from michaelkedar March 2, 2025 23:17
@cuixq cuixq merged commit d811e36 into google:main Mar 7, 2025
2 checks passed
@cuixq cuixq deleted the maven branch March 7, 2025 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants