-
Notifications
You must be signed in to change notification settings - Fork 921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make asset urls configurable #1006
base: main
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
How can I sign the CLA without a Google account? |
Unfortunately it's not possible to sign the Google CLA without a Google account. |
Then you can just accept my contribution without a CLA. As long as you stick to the terms of the Apache License, there is no need to grant Google more permissions. |
Unfortunately our rules do not allow contributions without a signed CLA. |
I can only shake my head at this. Well, ok, this is Google – so I probably should not be too surprised. This contribution is covered by the Apache license, and this has to be enough. What Google wants here is a permission to use the contribution under other terms, which is plain unacceptable. The Apache license, in contrast to other free software licenses, even has a paragraph expressly guaranteeing that contributions are covered by it. This change makes Docsy GDPR compliant, and apart from GDPR being a law for a major part of the world, it should be more or less self-evident that users' privacy protection matters more than some stupid CLA, especially when there is no single reason for requiring this CLA. And, as already stated: It seems that @magicbrothers would even grant a CLA if it could be sent without accepting Google's ToS on top before. |
Thank you for your feedback! I will take up with the folks managing the CLA process. |
@magicbrothers Good job and right on time, as people are getting fined now in Germany! -> #605 (comment) |
I too want to say that this topic is important for me. |
@magicbrothers, how do I set the link to a locally downloaded fille? Putting the following into my This is probably some HUGO related issue I do not understand and all I need to do is to put the files into the correct folder and use the correct path |
I have given up on this, due to the general foulness of the Go and Hugo ecosystems (which is demonstrated perfectly in this issue, its ignorance by the maintainers, and the refusal to let people contribute without unnecessarily subjugate themselves to Google. For anyone looking for a a sane alternative, I recommend looking at Zola and its Adidoks theme. |
Allows configuration (in
config.toml
andassets/scss/_variables_project.scss
) of own URLs instead of public CDNs.advances #605
One font is still loaded from jsdelivr.net, but I can't find it in the code.