-
Notifications
You must be signed in to change notification settings - Fork 921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scroll left toc to active entry #1023
base: main
Are you sure you want to change the base?
Scroll left toc to active entry #1023
Conversation
Useful when the left-side toc is longer than the screen. Fixes google#348 and google#257 This is an update of the original patch of narrenfrei
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
@narrenfrei do you want to take a look at this? |
Hi @LisaFC and @narrenfrei, have you had a chance to review this PR? |
I think in the netlify preview the functionality doesn't work, because the sample page ist built with the cached sidebar Also the script that adapts the sidebar menu when the sidebar cache is use have to set the id of the span to docsy/layouts/partials/sidebar.html Line 11 in 6488360
|
Many thanks for the comments, I'll try to fix them later this week |
@raum51 : I've added a line to add the id to the span, but if the cache limit is low, the scrolling doesn't work for some reason. Any ideas? |
Useful when the left-side toc is longer than the screen.
Fixes #348 and #257
This is an update of the original patch of narrenfrei
Notes: