Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect ui.ul_show with ui.sidebar_menu_foldable #1159

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

metafeather
Copy link

The docs are ambiguous about combining ui.sidebar_menu_foldable with ui.sidebar_menu_compact and ui.ul_show but the fix is trivial so that the desired number of levels of menus are automatically opened in the sidebar since $show already depends on $activepath

metafeather and others added 2 commits August 14, 2022 20:58
The docs are ambiguous about combining `ui.sidebar_menu_foldable` with `ui.sidebar_menu_compact` and `ui.ul_show` but the fix is trivial so that the desired number of levels of menus are automatically opened in the sidebar since `$show` already depends on `$activepath`
@LisaFC
Copy link
Collaborator

LisaFC commented Aug 15, 2022

Thanks for this - that seems like a neater solution!

@LisaFC
Copy link
Collaborator

LisaFC commented Aug 15, 2022

@raum51 do you want to take a look to make sure I haven't missed anything?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants