-
Notifications
You must be signed in to change notification settings - Fork 921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Expose cdn settings as params #1204
base: main
Are you sure you want to change the base?
Conversation
Maybe we could use the default function of hugo, and use the config parameters if set, or use the original cdns if not. |
I'll have a look at how the scripts partial would look if we used defaults. |
Sorry for the delay, I just pushed up changes to include defaults inside the templates. |
This moves the configuration of much of the cdn (js/css) into the configuration so they can be more easily maintained. Signed-off-by: Brad Beam <[email protected]>
Signed-off-by: Brad Beam <[email protected]>
I like the idea. This PR does not pull in the latest versions of the resources, however (e.g. it pulls in KaTeX 0.15.1, while latest version is 0.16.2.) Were great if this could be improved. |
I wanted to keep the scope of the change as minimal as possible. I think version bumps can be done as followups to this. |
This moves the configuration of much of the cdn (js/css) into the configuration
so they can be more easily maintained.
Signed-off-by: Brad Beam [email protected]