Replace jquery.js URL to a CDN location #432
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the advantage of using jsdelivr over code.jquery.com as our CDN? |
|
From this doc, it's a pretty good CDN. https://github.com/jsdelivr/jsdelivr#why-jsdelivr |
|
It brings up a good question though around what js we actually want to host as part of the repo, vs pulling in via cdn (especially as these resources are far less cacheable these days) We have a number of libraries now that we pull in via CDN, and a number that are either in the repo, or a git submodule Not sure i have a good answer fwiw; just interested :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.