Fix for logback version upgrade (#969)

* Fix for logback version upgrade * Addressing the review comments * Review comments * Review comments
google · Mar 4, 2024 · 0da54ad · 0da54ad
1 parent ace4fd4
commit 0da54ad
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 4 deletions.
diff --git a/bunsen/pom.xml b/bunsen/pom.xml
@@ -37,7 +37,7 @@
     <maven-javadoc.plugin.version>3.6.3</maven-javadoc.plugin.version>
     <maven-project-info-reports.plugin.version>3.5.0</maven-project-info-reports.plugin.version>
     <slf4j.version>2.0.12</slf4j.version>
-    <logback.version>1.4.12</logback.version>
+    <logback.version>1.5.0</logback.version>
   </properties>
 
   <modules>

diff --git a/pipelines/pom.xml b/pipelines/pom.xml
@@ -44,7 +44,7 @@
     <bunsen.version>0.5.14-SNAPSHOT</bunsen.version>
     <junit.version>4.13.2</junit.version>
     <slf4j.version>2.0.12</slf4j.version>
-    <logback.version>1.4.11</logback.version>
+    <logback.version>1.5.0</logback.version>
     <hapifhirVersion>6.10.4</hapifhirVersion>
     <hamcrest.version>2.2</hamcrest.version>
     <mockito.version>5.2.0</mockito.version>
@@ -92,6 +92,32 @@
         <artifactId>jcommander</artifactId>
         <version>${jcommander.version}</version>
       </dependency>
+
+      <!-- In the controller module, we import the pom of the artifact -
+       org.springframework.boot:spring-boot-dependencies to inherit the dependencyManagement
+       section of it. The logback versions defined below will take precedence over the versions
+       defined in the org.springframework.boot:spring-boot-dependencies artifact because the direct
+       dependency takes precedence other the transitive dependency. -->
+      <dependency>
+        <groupId>ch.qos.logback</groupId>
+        <artifactId>logback-classic</artifactId>
+        <version>${logback.version}</version>
+        <scope>runtime</scope>
+      </dependency>
+
+      <dependency>
+        <groupId>ch.qos.logback</groupId>
+        <artifactId>logback-core</artifactId>
+        <version>${logback.version}</version>
+        <scope>runtime</scope>
+      </dependency>
+
+      <dependency>
+        <groupId>ch.qos.logback</groupId>
+        <artifactId>logback-access</artifactId>
+        <version>${logback.version}</version>
+        <scope>runtime</scope>
+      </dependency>
     </dependencies>
   </dependencyManagement>
 
@@ -105,8 +131,6 @@
     <dependency>
       <groupId>ch.qos.logback</groupId>
       <artifactId>logback-classic</artifactId>
-      <version>${logback.version}</version>
-      <scope>runtime</scope>
     </dependency>
 
     <!-- Test deps -->