Updated "Fhir Data Pipes" concepts documentation #1242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1242 +/- ##
============================================
+ Coverage 51.38% 51.48% +0.10%
- Complexity 715 717 +2
============================================
Files 95 95
Lines 5916 5916
Branches 790 790
============================================
+ Hits 3040 3046 +6
+ Misses 2584 2579 -5
+ Partials 292 291 -1 ☔ View full report in Codecov by Sentry. |
bashir2
approved these changes
Nov 29, 2024
|
Hi @fredhersch when you have a chance please address the comments and merge this PR; thanks. |
LGTM Co-authored-by: Bashir Sadjad <[email protected]>
LGTM Co-authored-by: Bashir Sadjad <[email protected]>
LGTM Co-authored-by: Bashir Sadjad <[email protected]>
|
Thanks Bashir. I've accepted the fixes and suggestions. I don't have access to my cloudtop at the moment ... if you can make the suggested changes that would be great. Thanks |
bashir2
reviewed
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what I changed
Made changes to the Concepts documentation to bring up to speed with latest features
E2E test
TESTED: on local
Checklist: I completed these to help reviewers :)
I have read and will follow the review process.
I am familiar with Google Style Guides for the language I have coded in.
No? Please take some time and review Java and Python style guides.
My IDE is configured to follow the Google code styles.
No? Unsure? -> configure your IDE.
I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)
I ran
mvn clean packageright before creating this pull request and added all formatting changes to my commit.All new and existing tests passed.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master