-
Notifications
You must be signed in to change notification settings - Fork 32
fix spelling of repo name #15
base: master
Are you sure you want to change the base?
Conversation
@nickgeorge -- tagging you, as you seem last one to touch this repo, and wrote the contributing guide https://github.com/google/fhir-examples/blob/master/CONTRIBUTING.md |
Great catch, thanks a lot! Unfortunately we're not super well set up to accept external requests for boring technical reasons, but I'll make this change. |
Do those boring technical things need to be overcome ( and can I help )? I generally start with a small contribution to work out process ahead of more meaningful things. Is that also the case for https://github.com/google/fhir ??? I'm going to dig into that, which is why I am starting with the examples. |
@nickgeorge -- we can also close this PR once the changes have been made ( elsewhere, if unable to actually merge this ). |
It looks like this was closed: #18 but not actually merged? |
Separately, but seriously, what's the point of the CONTRIBUTING.md if you can not accept 'external' commits? https://github.com/google/fhir-examples/blob/master/CONTRIBUTING.md Wouldn't that be prudent to include in that doc [ I'd also make the change, but lol -- that's what we're talking about :-) ] |
Sorry, Fair enough... the boring technical reasons mostly have to do with how we internally mirror the repository to the google monorepo, so unfortunately I'm not sure you could help - BUT! we've actually made some real progress recently in fixing the contributors process. I wouldn't blame you for not believing me, because I'm not very good at engagement, but we are close to accepting outside contributions thanks to some great work by @suyashkumar. As for the pull request at hand - you are right... I fixed it internally but forgot to export :( doing that now... |
Done! Checked with @suyashkumar , we're thinking ~Q2 for accepting external contributions. Sorry again for bad engagement! |
I imagine that goes both for https://github.com/google/fhir and this repo? I'm also interested in ensuring this is something possible for most/all repos that are open ( with Contributing.MD ), so thinking larger than just FHIR. [ FHIR is relevant as I'm also playing with a 'healthcare circle' of Googlers and GDE's ] |
I may pull on some threads to aim to coordinate efforts across some other parts of Google -- it sounds like what @suyashkumar is doing might also be useful to a number of other projects hosted at https://github.com/google/ ... LOL -- but, you know, organizations, coordination, and such [ so not particularly optimistic ] |
In README the name of repo is misspelled.