New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: GemmaDecodeLayer init is not passed required world_size, rank in model_xla #75

Closed

DavidRV00 opened this issue Dec 24, 2024 · 0 comments · Fixed by #76

Contributor

DavidRV00 commented Dec 24, 2024

At https://github.com/google/gemma_pytorch/blob/main/gemma/model_xla.py#L530, the constructor for GemmaDecodeLayer needs to be passed a world_size and rank (not just config).

These are required, and without them a crash soon follows.

The text was updated successfully, but these errors were encountered:

DavidRV00 mentioned this issue

Add required world_size and rank to GemmaDecodeLayer init #76

Merged

pengchongjin closed this as completed in #76

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment