Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required world_size and rank to GemmaDecodeLayer init #76

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

DavidRV00
Copy link
Contributor

@DavidRV00 DavidRV00 commented Dec 24, 2024

fix #75

Just passing required arguments to the GemmaDecodeLayer __init__ in model_xla.

Copy link

google-cla bot commented Dec 24, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@pengchongjin
Copy link
Collaborator

Thanks for the fix, @DavidRV00 ! Looks good!

@pengchongjin pengchongjin merged commit 3294a89 into google:main Jan 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: GemmaDecodeLayer __init__ is not passed required world_size, rank in model_xla
2 participants