This repository has been archived by the owner on Dec 25, 2024. It is now read-only.
Add more tests to increase coverage. #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kordianbruck
approved these changes
Oct 29, 2020
schachmat
approved these changes
Oct 30, 2020
schachmat
suggested changes
Nov 4, 2020
| newSource: "source_1_b/file_1.txt", | ||
| newDiffFile: "f1_b_c.diff", | ||
| resultFile: "f1_a_c.diff", | ||
| oldSource: "mixed_old_source/f7.txt", |
There was a problem hiding this comment.
this seems like the same test case as the one from line 98. Also it seems you're not using the new test file mi_f6_os_od.diff anywhere.
There was a problem hiding this comment.
Um.. yes, actually
mixedModeFileTests used for testing MixedMode and MixedModeFile, while mixedModePathFileTests tests MixedModePath, which includes call to MixedModeFile and MixedMode.
It might be better to totally remove mixedModeFileTests and just test everything with mixedModePathFileTests?
But in that case we won't see directly which of inner function is failing, except from error messages.
* Move check if diff is out of content source to process of unchanged/deleted lines; * Used cmp.Equal in tests; * Add test case with f6; * allow processing empty diff files in MixedModePath; * check number of read diff files instead of handling error on read; * changed NewFileDiffReader to NewMultiFileDiffReader; * add missing colon; * add type to the nil assigment; * corrected calculation of StartLines and NumberOfLines in convertChunksToFileDiff;
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increased coverage from
70%to87%.A lot of test files have been replaced to new ones with more understandable names.