Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge discovery common #132

Closed
wants to merge 58 commits into from
Closed

merge discovery common #132

wants to merge 58 commits into from

Conversation

kevmoo
Copy link
Collaborator

@kevmoo kevmoo commented Jan 22, 2021

wibling and others added 30 commits March 9, 2015 12:30
This commit also adds the necessary tests for this functionality
Add DetailedApiRequestError and mapping from JSON
* Make everything strong-mode clean. Fix deprecation warnings for expectAsync. Make convert parameter for mapMap non-optional.

* Run dartfmt
Updates for Dart 2.0 core library changes (wave 2.2)
They're deprecated in the latest dev SDK, making Travis unhappy.

Updated SDK constraint, .cast() was introduced in dev.22.0.
Start and end are both inclusive in ByteRange, so it should be possible
to create a range of 0-0.

Fixes #6.
@google-cla
Copy link

google-cla bot commented Jan 22, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Jan 22, 2021
@kevmoo kevmoo requested review from davidmorgan and jonasfj January 22, 2021 23:37
@kevmoo
Copy link
Collaborator Author

kevmoo commented Jan 22, 2021

FYI: the history is ugly here because I merged in the history from the other repo

@kevmoo kevmoo force-pushed the merge_discovery_common branch from 058d4d1 to c0dce01 Compare January 22, 2021 23:43
@google-cla
Copy link

google-cla bot commented Jan 22, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@kevmoo
Copy link
Collaborator Author

kevmoo commented Jan 23, 2021

Doing the full history is a bit of a mess. Doing something else!

@kevmoo kevmoo closed this Jan 23, 2021
@kevmoo kevmoo deleted the merge_discovery_common branch January 25, 2021 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.