-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge discovery common #132
Conversation
This commit also adds the necessary tests for this functionality
Add DetailedApiRequestError and mapping from JSON
fix strong mode issues
* Make everything strong-mode clean. Fix deprecation warnings for expectAsync. Make convert parameter for mapMap non-optional. * Run dartfmt
…s_options.yaml' file [email protected] Review-Url: https://codereview.chromium.org/2905613002 .
Updates for Dart 2.0 core library changes (wave 2.2)
They're deprecated in the latest dev SDK, making Travis unhappy. Updated SDK constraint, .cast() was introduced in dev.22.0.
Start and end are both inclusive in ByteRange, so it should be possible to create a range of 0-0. Fixes #6.
Remove forbidden headers
Send client library identifier
Prepare a new release
Ignore uri not exists
The `dart:core` documentation clearly states errors represents a program failure that the programmer should have avoided. However, we throw a `DetailedApiRequestError` instance if the server responds 4xx/5xx.
Make `ApiRequestError` implement `Exception` and not `Error`.
Migrate to null safety
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
FYI: the history is ugly here because I merged in the history from the other repo |
058d4d1
to
c0dce01
Compare
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
Doing the full history is a bit of a mess. Doing something else! |
ApiRequestError
implementException
and notError
.