gpt_disk_io: Remove Drop impl and add io accessor #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Once a user has found the partition entry they are looking for, they may want to read that data. In order to do that, they will need their BlocKIO device back. This provides a fn (`io`) to get it back. In order to facilitate the usage of moving `io` out of self, the impl Drop must be removed. It's up to the user know to implement `flush` on the drop of their specific Disk.
schultetwin1
force-pushed
the
remove_drop_add_io
branch
from
9b909f8 to
281fd3c
Compare
|
Was able to use a mut ref as suggested by @nicholasbishop in #244. This is no longer needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once a user has found the partition entry they are looking for, they may want to read that data. In order to do that, they will need their BlocKIO device back. This provides a fn (
io) to get it back.In order to facilitate the usage of moving
ioout of self, the impl Drop must be removed. It's up to the user know to implementflushon the drop of their specific Disk.This was created as a suggested fix for #244