-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Update '.prettierrc.json' to include trailingComma: "all"
to match internal Google config
#822
Conversation
Can we rebase this? Change looks good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I am not good at git, my brain has been permanently disfigured by fifteen years of using nothing but Piper/Perforce. I think I screwed this up somehow even though I was following a github help page. If you want to help me that's fine, or if you want to just make the change yourself that's fine too. I've spent half an hour on this and I'm quite frustrated. |
Ok I think I fixed it (thanks again for the help!) |
Note: the commit message needs to follow conventional commits. Can you amend your commit message? This change will be messy for lots of repos using |
Use value 'all' to match internal Google config
Done |
trailingComma: "all"
to match internal Google config
No need to manually bump the version, a bot will create the release PR and handle versioning
fixes #662