Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use combinedClickable as basis of UnboundedRippleButton #2531

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kevinGC
Copy link

@kevinGC kevinGC commented Mar 1, 2025

WHAT

Allow users of user of UnboundedRippleButton to use features like long press.

WHY

Long press is useful for UI interactions, e.g. for a button that skips forward 30 seconds upon clicking, and skips to the end when held.

HOW

Use combinedClickable instead of clickable.

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

@yschimke
Copy link
Collaborator

yschimke commented Mar 4, 2025

This isn't passing in any additional lambda, so not sure it's letting anyone pass this in.

This allows users of user of UnboundedRippleButton to use features like
long press.
@kevinGC
Copy link
Author

kevinGC commented Mar 4, 2025

Whoops, embarrassing omission. Updated, plus updated the relevant bit of the API file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants