Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When unmarshaling, check the payload's type even if no ID is included #125

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CrushedPixel
Copy link
Contributor

As of now, request.unmarshalNode only checks the payload's type field if the id field is set. This doesn't make sense when unmarshalling a POST payload, as per jsonapi spec the client is not required to set an id, but is required to set the correct type for the resource they're creating.

This PR addresses this issue by simply moving the type check before the check for an empty id field.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@CrushedPixel
Copy link
Contributor Author

Signed it.

@googlebot
Copy link

CLAs look good, thanks!

@akashjain132
Copy link

Any update on this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants