When unmarshaling, check the payload's type even if no ID is included #125
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of now,
request.unmarshalNode
only checks the payload'stype
field if theid
field is set. This doesn't make sense when unmarshalling aPOST
payload, as per jsonapi spec the client is not required to set anid
, but is required to set the correcttype
for the resource they're creating.This PR addresses this issue by simply moving the type check before the check for an empty
id
field.