Fix code scanning alert no. 21: Uncontrolled data used in path expression #78
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/google/litmus/security/code-scanning/21
To fix the problem, we need to ensure that the
filename
parameter is sanitized and validated before it is used to construct thetemp_filename
. We can use thewerkzeug.utils.secure_filename
function to sanitize the filename, ensuring it does not contain any special characters or path traversal sequences. Additionally, we should normalize the path to ensure it stays within the intended directory.secure_filename
function fromwerkzeug.utils
.secure_filename
to sanitize thefilename
parameter.temp_filename
using the sanitized filename.Suggested fixes powered by Copilot Autofix. Review carefully before merging.