Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code scanning alert no. 21: Uncontrolled data used in path expression #78

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amgoogle
Copy link
Collaborator

@amgoogle amgoogle commented Oct 2, 2024

Fixes https://github.com/google/litmus/security/code-scanning/21

To fix the problem, we need to ensure that the filename parameter is sanitized and validated before it is used to construct the temp_filename. We can use the werkzeug.utils.secure_filename function to sanitize the filename, ensuring it does not contain any special characters or path traversal sequences. Additionally, we should normalize the path to ensure it stays within the intended directory.

  1. Import the secure_filename function from werkzeug.utils.
  2. Use secure_filename to sanitize the filename parameter.
  3. Construct the temp_filename using the sanitized filename.

Suggested fixes powered by Copilot Autofix. Review carefully before merging.

…sion

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Copy link

google-cla bot commented Oct 2, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant