Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.7, 3.8 and openjdk>8 to build matrix #372

Merged
merged 8 commits into from
Dec 30, 2019
Merged

Add Python 3.7, 3.8 and openjdk>8 to build matrix #372

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
472d78d
Add Python 3.7 and 3.8 to build matrix
StephenBrown2 Dec 27, 2019
80ff37a
Set 'dist' to latest LTS: 'bionic'
StephenBrown2 Dec 27, 2019
2a0693a
Set dist globally
StephenBrown2 Dec 27, 2019
d9ad127
Add more javas (oracle/openjdk 9-13)
StephenBrown2 Dec 27, 2019
067721b
Java 8 actually requires dist: trusty
StephenBrown2 Dec 27, 2019
1afa3e6
Bump down dist for Oracle Javas
StephenBrown2 Dec 27, 2019
fc5464d
Remove Non-LTS oraclejdks
StephenBrown2 Dec 27, 2019
c5748b5
Comment out failing java versions for now.
StephenBrown2 Dec 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,30 @@ matrix:
- ~/bin/bazel test --test_output=all ${OLC_PATH}:all
- cd ${OLC_PATH} && bash format_check.sh

# Python implementation. Lives in python/, tested with bazel.
- language: python
python: 3.7
dist: bionic
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's prompting this change? We currently have the dist set to trusty globally - do Python 3.7 and 3.8 need to specifically run with bionic?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, trusty does not support python 3.7 or 3.8. The Travis build for the first commit failed on Python 3.7 and on Python 3.8 with the reason: Unable to download 3.(7|8) archive. The archive may not exist. Please consider a different version.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, thanks for the clarification. Would you mind setting the global dist to bionic and seeing if everything still passes? I'd prefer to keep everything in sync if possible.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do. 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears that Java 8 is no longer available on bionic, as it is EOL. Can bump the dist down to xenial, or set it specifically for java8 and add later jdks to be sure they work as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like your second approach - let's default to bionic and set it to older dist versions as needed. Thanks for doing this!

env: OLC_PATH=python
script:
- wget -O install.sh "https://github.com/bazelbuild/bazel/releases/download/0.24.1/bazel-0.24.1-installer-linux-x86_64.sh"
- chmod +x install.sh
- ./install.sh --user && rm -f install.sh
- ~/bin/bazel test --test_output=all ${OLC_PATH}:all
- cd ${OLC_PATH} && bash format_check.sh

# Python implementation. Lives in python/, tested with bazel.
- language: python
python: 3.8
dist: bionic
env: OLC_PATH=python
script:
- wget -O install.sh "https://github.com/bazelbuild/bazel/releases/download/0.24.1/bazel-0.24.1-installer-linux-x86_64.sh"
- chmod +x install.sh
- ./install.sh --user && rm -f install.sh
- ~/bin/bazel test --test_output=all ${OLC_PATH}:all
- cd ${OLC_PATH} && bash format_check.sh

# Ruby implementation. Lives in ruby/
- language: ruby
rvm: 2.6.3
Expand Down