Change Travis mentions to "CI" or remove as appropriate #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
drinckes
requested changes
Jan 8, 2025
| @@ -22,13 +22,8 @@ RETURN=0 | |||
| for FILE in `ls *.[ch] */*.[ch]`; do | |||
| DIFF=`diff $FILE <($CLANG_FORMAT $FILE)` | |||
| if [ $? -ne 0 ]; then | |||
| if [ -z "$TRAVIS" ]; then | |||
There was a problem hiding this comment.
The original intention is to format the files if running locally, but to fail the CI if there are differences.
Removing this will format the file in the CI test, but not commit it, and the CI will succeed.
I suggest replacing $TRAVIS with $GITHUB_WORKFLOW, here and below, since that should be set in the CI run.
There was a problem hiding this comment.
Is our intention that GitHub CI will have access to make commits here and rewrite code for style? Or just that CI will error on code style failure?
There was a problem hiding this comment.
Just throw errors. I think I had it doing commits in the Travis CI days long ago but I'd rather keep it simple tbh.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes dead code for Travis CI which has not run in years. Updates wording mentioning TravisCI to instead mention CI.