Fix and add CI checks for autoflake, isort
#1049
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, I agree these cleanups are important. I am enabling internal tooling to look for these and additional lint violations, and closing this PR. Also #1198 cleans up existing unused imports and I'll make another PR to fix the import ordering. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
autoflake cleans up unused imports and useless pass statements.
isort manages import sorting.
I configured the profiles that would have the smallest diff and seemed most reasonable.
The really interesting part (IMO) is the addition of these as a GitHub Actions CI job that should prevent non-conforming code from being added and hence keep a more consistent code style in the repo.
This change is