-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pip installs on Windows. #882
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fix should resolve the issue (I'll test it later on).
Thing is, is it still required to drop support for protocol buffer on windows?
Seems like there was an attempt here:
#723
1dc878b
to
b583084
Compare
@Hfusi0n please try with this commit. I've ported the relevant bits from the other pull request. |
I should have tested this pull request before referencing to it, sorry... I think first commit should be merged making sure installation doesn't throw exceptions I tested your first commit and it seems to work as excepted. Second commit might need to be tested more - see below error log. EDIT It's possible (and tested on my laptop) to support protoc on windows if using the compiled version by Google: I've added the protoc executable to my PATH and changed the setup file for the prefix to include protoc include directory and everything worked fine. Since protoc is a third party to this project I'm not really sure what to do here. running build_proto During handling of the above exception, another exception occurred: Traceback (most recent call last): |
copied from google#882
git conflicts |
The setup script had an undefined variable when installing on Windows. It shouldn't get into that code in the first place.
Fixes #881
This change is