experimental: refactor to simplify and compartmentalise #454
Conversation
This fixes bugs happening when the relative path is used Signed-off-by: David Korczynski <[email protected]>
Signed-off-by: David Korczynski <[email protected]>
Signed-off-by: David Korczynski <[email protected]>
Signed-off-by: David Korczynski <[email protected]>
Signed-off-by: David Korczynski <[email protected]>
Signed-off-by: David Korczynski <[email protected]>
Signed-off-by: David Korczynski <[email protected]>
Signed-off-by: David Korczynski <[email protected]>
Signed-off-by: David Korczynski <[email protected]>
Signed-off-by: David Korczynski <[email protected]>
|
/gcbrun skip |
Signed-off-by: David Korczynski <[email protected]>
Signed-off-by: David Korczynski <[email protected]>
|
/gcbrun skip |
Signed-off-by: David Korczynski <[email protected]>
| self.build_suggestion: AutoBuildContainer = build_suggestion | ||
| self.build_script: str = '' | ||
| self.build_directory: str = '' | ||
| self.executable_files_build: Dict[str, List[str]] = {} |
There was a problem hiding this comment.
nit: dict[str, list[str]]
There was a problem hiding this comment.
We can't -- this code runs in the oss-fuzz base images which relies on Python 3.8 and the typing is a Python3.9+ thing (see initial PR comment)
| all_build_scripts: List[Tuple[str, str, AutoBuildContainer]], | ||
| initial_executable_files: Dict[str, List[str]]) -> Dict[str, Any]: | ||
| all_build_scripts: List[Tuple[str, str, AutoBuildContainer]] | ||
| ) -> Dict[str, BuildWorker]: |
There was a problem hiding this comment.
nit: list[tuple[str, str, AutoBuildContainer]], dict[str, BuildWorker]
There was a problem hiding this comment.
We can't -- this code runs in the oss-fuzz base images which relies on Python 3.8 and the typing is a Python3.9+ thing (see initial PR comment)
experimental/c-cpp/manager.py
Outdated
|
|
||
| The harness should be in libFuzzer style, with the code wrapped in `int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size)`. | ||
|
|
||
| Please wrap all code in <code> tags and you should include nothing else but the code in your reply. Do not include any other text. | ||
|
|
||
| Make sure the ensure strings passed to the target are null-terminated. | ||
|
|
||
| There is one rule that your harness must satisfy: all of the header files in this library is %s. Make sure to not include any header files not in this list. | ||
| There is one rule that your harness must satisfy: all of the header files in this library is {str(headers_to_include)}. Make sure to not include any header files not in this list. |
There was a problem hiding this comment.
Same above
Do we need to cast headers_to_include explicitly with str()?
There was a problem hiding this comment.
BTW, could this be in a template file in the final version?
Also, could we define repeated lines once and reuse them to avoid repetitions?
There was a problem hiding this comment.
Same above Do we need to cast headers_to_include explicitly with str()?
We don't! thanks, fixed!
There was a problem hiding this comment.
BTW, could this be in a template file in the final version? Also, could we define repeated lines once and reuse them to avoid repetitions?
Yep, I'll look at doing this when merging the two #450 -- for the moment it's nice to have this in a single module as it makes for easy copying in/out of the containers as some development of this module happens within base-builder container environments. I will address this later though.
Signed-off-by: David Korczynski <[email protected]>
|
/gcbrun skip |
Refactors the from-scratch logic by:
Note, in the
managerandbuild_generatorwe can't remove the use ofListandDictsince it relies on the Python from OSS-Fuzz, which hasn't migrated tolistanddictyet.This is working towards #450